Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed incorrect locale references (#26218) #26222

Merged
merged 2 commits into from
Jul 29, 2023
Merged

Fixed incorrect locale references (#26218) #26222

merged 2 commits into from
Jul 29, 2023

Conversation

GiteaBot
Copy link
Contributor

Backport #26218 by @kerwin612

Fixed two incorrect headers for setting the page navigation bar:

  • User settings page, should not use the title "org.settings"
  • Repo settings page, should not use the title "org.settings"

@kerwin612 @GiteaBot
Fixed incorrect locale references (go-gitea#26218)
359a9a6 
Fixed two incorrect headers for setting the page navigation bar:
* User settings page, should not use the title "`org.settings`"
* Repo settings page, should not use the title "`org.settings`"
@GiteaBot GiteaBot added type/bug topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 29, 2023
@GiteaBot GiteaBot added this to the 1.20.3 milestone Jul 29, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 29, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 29, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 29, 2023
@silverwind silverwind enabled auto-merge (squash) July 29, 2023 15:19
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 29, 2023
@denyskon denyskon added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Jul 29, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 29, 2023
@silverwind silverwind merged commit 2122743 into go-gitea:release/v1.20 Jul 29, 2023
20 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 29, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@denyskon denyskon denyskon approved these changes

@silverwind silverwind silverwind approved these changes

@lunny lunny Awaiting requested review from lunny

@puni9869 puni9869 Awaiting requested review from puni9869

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.20.3
Development

Successfully merging this pull request may close these issues.
5 participants
@GiteaBot @silverwind @denyskon @delvh @kerwin612